Skip to content

install: add --no-binary option - #5600

Merged
abn merged 1 commit into
python-poetry:masterfrom
abn:install-no-binary
May 14, 2022
Merged

abn merged 1 commit into
python-poetry:masterfrom
abn:install-no-binary

Conversation

@abn

@abn abn commented May 13, 2022 •

Copy link
Copy Markdown
Member

This changeset introduces a familiar option from pip for Poetry's install command. Users can now use --no-binary :all:|:none:|package to indicate they do not want to instal lthe binary distribution of packages.

Resolves: #1316
Resolves: #5599
Resolves: #365

@abn
abn requested a review from a team May 13, 2022 01:34
@abn
abn force-pushed the install-no-binary branch from 5536993 to 2284ac9 Compare May 13, 2022 15:04
@abn
abn force-pushed the install-no-binary branch from 2284ac9 to f8535fc Compare May 13, 2022 15:21
@abn abn added the area/docs Documentation issues/improvements label May 13, 2022
@github-actions

github-actions Bot commented May 13, 2022 •

Copy link
Copy Markdown

Deploy preview for website ready!

✅ Preview
https://website-ea5x575mk-python-poetry.vercel.app

Built with commit f8535fc.
This pull request is being automatically deployed with vercel-action

@abn abn added area/cli Related to the command line area/installer Related to the dependency installer labels May 13, 2022
@abn
abn merged commit feb11b1 into python-poetry:master May 14, 2022
@abn
abn deleted the install-no-binary branch May 14, 2022 08:29
abn added a commit to abn/poetry that referenced this pull request May 14, 2022
This change replaces the `--no-binary` option introduced in python-poetry#5600 as
the original implementation could cause inconsistent results when the
add, update or lock commands were used.

This implementation makes use of a new configuration
`installer.no-binary` to allow for user specification of sdist
preference for select packages.
abn added a commit to abn/poetry that referenced this pull request May 14, 2022
This change replaces the `--no-binary` option introduced in python-poetry#5600 as
the original implementation could cause inconsistent results when the
add, update or lock commands were used.

This implementation makes use of a new configuration
`installer.no-binary` to allow for user specification of sdist
preference for select packages.
neersighted pushed a commit that referenced this pull request May 14, 2022
This change replaces the `--no-binary` option introduced in #5600 as
the original implementation could cause inconsistent results when the
add, update or lock commands were used.

This implementation makes use of a new configuration
`installer.no-binary` to allow for user specification of sdist
preference for select packages.
@fredrikaverpil

fredrikaverpil commented May 15, 2022 •

Copy link
Copy Markdown
Contributor

@abn this is awesome for grpcio which doesn't supply ARM builds 🎉

@abn

abn commented May 15, 2022

Copy link
Copy Markdown
Member Author

@fredrikaverpil be sure to check #5609.

@fredrikaverpil

Copy link
Copy Markdown
Contributor

@fredrikaverpil be sure to check #5609.

@abn Ah, I see. Thanks!
Looks like a better implementation to me, as it becomes opt-in. For example a missing ARM build doesn't require building on Intel too by default. 👍

@tensionhead tensionhead mentioned this pull request Jul 29, 2022
3 tasks done
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/cli Related to the command line area/docs Documentation issues/improvements area/installer Related to the dependency installer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow poetry add to force build dependencies from source How to add a dependency with --no-binary option Equivalent of pip install --no-binary

3 participants